The same applies to many spine surgeries for back pain. Most interventional treatments for pain (surgery, minimally invasive interventions, injections, etc) have a limited duration of efficacy. But if you can give someone with severe life altering pain some relief for even a few years, you can alter the trajectory of their life in a positive way.
So long as the patient is honestly aware of the pros and cons, they can make the choice to proceed or not based on what's important to them.
I currently believe the most effective systems are the ones that require the least tinkering by the patient - even if their average magnitude of effect is less effective than the "best" systems in the field. Every time a patient has to charge, they're reminded they're a "chronic pain person." Every time they have to be reprogrammed, they're reminded of this too. It becomes a self fulfilling prophecy. So I think systems requiring the least intervention by the patient have tended to work best for me. From this perspective, really long battery life (Eterna), and dynamic adaptation (Saluda) are giving me the best results currently. I've also found systems with short duty cycles (short periods of stimulation interspaced by larger periods of quiescence) tend to be more durable. Nevro's and Medtronic's recharge burden is too high. Hopefully that will change with their new generation of products.
Currently, there are systems that are great at one or two elements of durability, but no system has them all. I'm hopeful that we're not far off from a single system with months long battery life, dynamic adaptation, and short duty cycles.