Let me try to be less of a jack-ass.
I AM NOT A LAWYER, but my instinct is that the term "satisfactory delivery of said product" would be open to some interpretation. Unless there are specifics outlining it (and you + lawyer are happy with them) I would be very wary of the term. In fact, I wouldn't sign a damn thing on any business contract without a lawyer's approval (few hundred dollars now >> screwed later). This is especially true with your friend the venture capitalist.
@Law2Doc may be interested in offering a more informed opinion (sorry you're the only lawyer I'm aware of on this forum).
The reason I don't like this deal is that I'm confused by what it is you're offering, besides coordination and risk. I'm also confused why it is you think it's appropriate to calculate costs based on an assumption of extreme success (1 million + subscribers and 100,000+ active users who apparently don't get bored and move on).
I can understand the venture capitalist: if she's patient enough, she will get her money back from you one way or another. You'll be a doctor if you make it through med. school. She can beat it out of you then.
I can understand the developers: you'll be paying them before you know whether or not the project is truly successful (once the game is completed).
I don't understand this for you. Eventually, you're almost guaranteed a spot among the top earners. Even with high debt.
After you've finished training, a small investment and side business will be feasible. You will have the money to found it yourself, assuming you are patient and careful. You will also have a fall-back if something goes wrong (being a doctor). You can quit medicine if it's wildly successful, or simply pursue more app development upon completion.
Before you've finished training, a small investment and side business are difficult. Medical school requires a lot of time, even during the first two years. If something goes wrong, you have your student debt, a pissed venture capitalist, and a failed business to run. It also may impact your competitiveness as an applicant if it takes more time than you anticipate.
If it is successful, you seem to have projected it will make around 30-60k/year AFTER the first year. As lovely as that money is, it will be offset by the cost of starting and by the cost of maintaining it, updating it, taxes, etc.
It will also be relatively small potatoes by comparison to a higher future income, which you will risk by pursuing this.
I am a very risk averse person, and I sure as hell would not do this. I wish you the best of luck with whatever you decide, and with school in general.