Stroke and critical care neuro used to be more intertwined. They are now separate fellowships. Stroke physicians are more accurately called vascular neurologists. Yes, they work up and treat acute strokes. They also see patients in clinic, where they manage a variety of vascular neurologic issues. Many also do general neurology, depending on the setting. Most importantly, they are in a position to do clinical and basic science research on the causes, management, and primary/secondary prevention of stroke.
Neurocritical care physicians manage all neurologic disease that renders the patient critically ill. This includes ICH, AIS, SAH, trauma, SE, CNS infections, and a myriad of other CNS and PNS conditions that I don't care to list. Until a few years ago, these physicians were also typically boarded in stroke as well, although as I have said, they are now separate. Many do not have clinics, and devote their time to clinical and research duties. Critical care time is still (currently) billed fairly well, and so there is decent earning potential. The issue is, you are not typically in private practice, so your department is doing the earning, not you (directly). It costs a lot of money to build, maintain, and support a full NCCU.
Both stroke and NCCU physicians can expect to work unusual hours, due to the acute and uncompromising nature of their jobs. The fellowships themselves are also often not a walk in the park. Expect to work 80 hours per week at least during a neurocritical care fellowship -- and they aren't 80 easy hours. Think chest tubes, central lines, and acute intubations, with overnights and 30+ hour shifts.