There are some troubling things economically in the field, as there are in many fields. And, certainly when accounting for inflation and real dollars, psychology (and other fields) is not as lucrative as it used to be. Still, there is a diversity of incomes within psychology. There is room to make money, I also think some of you folks are a tad entitled. I didn't want to use that word, but I'm not sure how else to describe it. In many ways, I am right there with you. But, the grass is not quite as luxurious on the other side as some are painting it. Nor is it quite so brown on this side of the fence. $100,000 a year jobs are not that easy to get. If you majored in business, you probably wouldn't be making that. The averages are much lower. Could you? Sure. Could you make 100,000 a year as a billing person working on commission in a medical office? Maybe. As a real estate agent? Sure. Car salesman? Of course. But, how much of an outlier would you have to be? What would you have to do to secure that income? Take a look at the average income in the US. Take a look at the average incomes of someone with a BS, with an MS/MA/MBA, with a JD, MD, PhD. Psychology is not that bad, just accounting for the average Joe that enters the field wanting to be a therapist. They make okay money. I think the US/world has changed. Things aren't as stable. There's no guarantee that you will be able to work at the same place for 30 years and retire comfortably. And, there's a perception that you could lose your job at any time. When that's looming, 100,000 doesn't seem so great.
I think too many people are looking at "psychologist" as the destination when careers are far more varied than that. I wish I knew that I would be making 6 figures and that it would be constantly increasing through the end of my career 30-40 years down the road. I don't know that. But, I can say that, at least for me, I made 16-24,000 a year through grad school with no tuition and have a low 6 figure income within 5 years of finishing my postdoc. My job is interesting. I get to do whatever research I feel like so long as I publish and get grants. I do a day a week of clinical work, because I like it. I take a class here or there to learn something new (and I'm paid for it). I am never on call. I don't work at home, often, other than reading and maybe writing if I feel like it. I don't teach unless it's an invited lecture somewhere. I have a few administrative responsibilities, acting as a statistical consultant, and the like. I have traveled to many different countries and to a large chunk of the United States presenting and talking about science. If I keep getting grants and publishing, my income will likely go up substantially. Other very successful researchers I know that are deeper into their careers are operating well north of 200K a year. To me, that sounds like a fun lifestyle. Now, there are downsides. I have to keep getting grants. My position, despite the "tenure-track" label is all soft money. If I don't get tenure, it's over. The competition level is fierce. I have to deal with the increasing demands of IRB.
Clinically, you can do similar things, work with a diverse range of settings, add in some forensics and make a good income. You could start a treatment center, employ a range of specialties, service a specific population. Whatever. Be creative.
Now, these types of careers are not as stable or as easy to maintain as, say, walking into a pre-made clinical position as a psychologist, social worker, physician, speech pathologist, etc.. . And, in that respect, psychology isn't the most lucrative field. It's not bad, but not great. But, would I want the lifestyle of a practicing physician? No. The more difficult question is would I want the lifestyle of an academic physician with grants? And, I'd have to say yes, to that. Because it is little different than my current gig but with extra money. Though, even that, isn't definitive. I liked graduate school. I like the skillset I bring to the table. Thus far, this has been a fun ride.
I think we should be working to make psychology better. Get rid of the ills that ail it. As young aspiring psychologists, we can see something that is affecting many fields, the impact of subsidized freely available loan monies. Crappy schools = crappy outcomes. I think that is the source of much disgruntlement in the field. Going to school for 5 years, racking up 100K+ debt, not being competitive for cool internships, postdocs and jobs = dissatisfaction. You see a lot of people on here deciding between social work and psychology. Is this the stuff high incomes are made of? No. And, it shouldn't be.